sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Hoh (Jira) <j...@apache.org>
Subject [jira] [Commented] (SLING-8802) JcrResourceBundle should not consider dictionaries with a basename, if no basename is provided
Date Fri, 25 Oct 2019 13:05:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-8802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959747#comment-16959747
] 

Jörg Hoh commented on SLING-8802:
---------------------------------

I raised a PR for this: https://github.com/apache/sling-org-apache-sling-i18n/pull/2

> JcrResourceBundle should not consider dictionaries with a basename, if no basename is
provided
> ----------------------------------------------------------------------------------------------
>
>                 Key: SLING-8802
>                 URL: https://issues.apache.org/jira/browse/SLING-8802
>             Project: Sling
>          Issue Type: Improvement
>          Components: i18n
>    Affects Versions: i18n 2.5.14
>            Reporter: Jörg Hoh
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In  a situation where 2 dictionaries are available (one with a basename configured, the
other without any basename), the {{JcrResourceBundle}} will load (and merge) both if no basename
is provided (see [1]).
> This breaks applications where basenames are used to separate multiple ResourceBundles
from each other, and there are definitely cases where the basename is not provided (and thu
assumed as {{null}}).
> I would propose to make the behavior consistent and return only dictionaries with no
basename configured if basename is null.
> [1] https://github.com/apache/sling-org-apache-sling-i18n/blob/master/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundle.java#L340



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message