sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Schaefer (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SLING-8799) Deleting converted CPs in local maven repo makes rebuild fail
Date Mon, 28 Oct 2019 16:11:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961202#comment-16961202
] 

Andreas Schaefer commented on SLING-8799:
-----------------------------------------

This is to reproduce the issue with the attached sample project:
 * Extract Project
 * Build with 'mvn clean install'
 * Delete the create folder in the local repo as 'com/adobe/aem/guides/skyline/test'
 * Rebuild with 'mvn clean install'
 * The build fails as it tries to find the ui.apps converted cp file
 * Then clean the project with 'mvn clean'
 * Now the build with 'mvn install' works

This seems to be an issue because the Preprocessor adds the ui.apps.json from the generated FM
folder (target/fm) as dependency which contains the dependency for the converted cp file.

 

This is not a big issue but this can cause some confusion when users start running into
issues and try to clean up their local Maven repo. I guess the best would be to check if
the dependencies exist in the Preprocessor and throw an explaining exception as Maven does
not know what this dependency is about.

 

> Deleting converted CPs in local maven repo makes rebuild fail
> -------------------------------------------------------------
>
>                 Key: SLING-8799
>                 URL: https://issues.apache.org/jira/browse/SLING-8799
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>    Affects Versions: slingfeature-maven-plugin 1.1.6
>         Environment: Latest Sling, Java 8, Maven 3.6.1
>            Reporter: Andreas Schaefer
>            Assignee: Andreas Schaefer
>            Priority: Major
>         Attachments: secondary-test.zip
>
>
> To recreate this issue:
>  * POM with a CP Conversion (Sling Feature Converter Maven Plugin) and FM Aggregation
(Sling Feature Maven Plugin)
>  * CP Conversion is in a phase before FM Aggregation
>  * Build with mvn clean install
>  * Go to the local maven repo (.m2) and find the converted ZIP files
>  * Delete the ZIP files or delete the entire group
>  * Rebuild with mvn clean install
>  * This build fails because Maven cannot find the converted ZIP files
> If the rebuild is split and the clean is executed ahead (mvn clean;mvn install) it works.
>  
> This seems to be either an issue with the Sling Feature Maven Plugin's test ahead of
the execution or with the CP Converter Plugin to not install the converted cps correctly when
target contains the generated ZIP files but the local repo does not have them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message