sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikas Saurabh (Jira)" <>
Subject [jira] [Commented] (SLING-8710) IndexingClient should have configurable lanes
Date Mon, 16 Sep 2019 13:29:00 GMT


Vikas Saurabh commented on SLING-8710:

Just created a PR
and realized [~volteanu]'s comment.

I can update the PR to have an explicit {{setLanes}} method - although, I think that would
likely require updating tests using a pattern like {{client.adaptTo(IndexingClient.class).waitForAsyncIndexing}}.
So, maybe it's ok to simply have extra csv of lanes in sling config map itself?

> IndexingClient should have configurable lanes
> ---------------------------------------------
>                 Key: SLING-8710
>                 URL:
>             Project: Sling
>          Issue Type: Improvement
>          Components: Launchpad
>            Reporter: Vikas Saurabh
>            Priority: Major
>              Labels: sling-IT
>          Time Spent: 10m
>  Remaining Estimate: 0h
> {{IndexingClient}} currently relies on {{OsgiConsoleCient}} to peek into system's lane
configuration. That, in turn, requires access to /system/console which might be blocked on
the system which is being tested.
> As indexing lanes in a setup isn't a very dynamic property, a quick work around could
be for {{IndexingClient}} to allow setting up "expected index lanes in target setup".
> This issue would be an improvement over what was implemented in SLING-7169. [~rombert]
and [~volteanu], since most of the comments over there are from you guys, wdyt about this

This message was sent by Atlassian Jira

View raw message