From dev-return-98546-archive-asf-public=cust-asf.ponee.io@sling.apache.org Sat Jul 27 14:13:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CD807180685 for ; Sat, 27 Jul 2019 16:13:02 +0200 (CEST) Received: (qmail 90811 invoked by uid 500); 27 Jul 2019 14:13:02 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 90555 invoked by uid 99); 27 Jul 2019 14:13:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jul 2019 14:13:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F13FDE2F3C for ; Sat, 27 Jul 2019 14:13:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3F14C2660A for ; Sat, 27 Jul 2019 14:13:00 +0000 (UTC) Date: Sat, 27 Jul 2019 14:13:00 +0000 (UTC) From: "Carsten Ziegeler (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-8541) slingfeature-maven-plugin should allow for generated feature model files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894464#comment-16894464 ] Carsten Ziegeler commented on SLING-8541: ----------------------------------------- I don't want the converter be part of the slingfeature plugin; it's not it's business to convert other things into features. I assume your features end up somewhere in a target directory, right? So you need to configure this for the slingfeature plugin to be picked up, you can either do this using (which defaults to src/main/features) or we can use a new directive. The latter allows to combine local features (from src/main/features) with generated (or converted) features from other plugins. The cpconverter being one of it. But the conversion should not be part of the slingfeature plugin > slingfeature-maven-plugin should allow for generated feature model files > ------------------------------------------------------------------------ > > Key: SLING-8541 > URL: https://issues.apache.org/jira/browse/SLING-8541 > Project: Sling > Issue Type: New Feature > Components: Feature Model > Affects Versions: slingfeature-maven-plugin 1.0.4 > Reporter: Andreas Schaefer > Priority: Major > Fix For: slingfeature-maven-plugin 1.0.6 > > > The Sling Feature Maven Plugin is checking that the feature model folder is containing feature model files when the plugin is started. > This fails when the FM are generated prior to the execution of the Sling Feature Maven Plugin. This check should be either made optional or moved prior to the actual execution of the Plugin's goal. -- This message was sent by Atlassian JIRA (v7.6.14#76016)