From dev-return-97593-archive-asf-public=cust-asf.ponee.io@sling.apache.org Thu Jun 13 12:47:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0414718064E for ; Thu, 13 Jun 2019 14:47:20 +0200 (CEST) Received: (qmail 14708 invoked by uid 500); 13 Jun 2019 12:47:20 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 14697 invoked by uid 99); 13 Jun 2019 12:47:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jun 2019 12:47:20 +0000 From: GitBox To: dev@sling.apache.org Subject: [GitHub] [sling-org-apache-sling-feature-analyser] karlpauls commented on issue #16: SLING-8251 - Support checking dependencies for content packages Message-ID: <156043003511.355.10615136508933883875.gitbox@gitbox.apache.org> Date: Thu, 13 Jun 2019 12:47:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit karlpauls commented on issue #16: SLING-8251 - Support checking dependencies for content packages URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/16#issuecomment-501687686 @simonetripodi, that is problematic as deleteOnExit is not going to delete dirs if they are not empty. I was more thinking about not removing the try/finally but rather change the deleteRecursive to look like: ``` private void deleteOnExitRecursive(File file) { if (file.isDirectory()) { File[] childs = file.listFiles(); if (childs != null) { for (File child : childs) { deleteRecursive(child); } } } file.deleteOnExit(); } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services