sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carsten Ziegeler <cziege...@apache.org>
Subject Re: [DISCUSS] proposing first apiregions-model release
Date Wed, 26 Jun 2019 11:01:52 GMT
Hi Simo,


I did a quick review, two comments:

https://github.com/apache/sling-org-apache-sling-feature-apiregions-model/blob/master/src/main/java/org/apache/sling/feature/apiregions/model/io/json/package-info.java

is missing a package version

and you could use the latest sling-bundle parent pom which already 
contains the required configuration to build bundles, making your pom 
smaller


Regards

Carsten


Simone Tripodi wrote
> Hi all,
> 
> is anybody available to do a quick review, please? Just to make sure
> the new bundle satisfies all the requirements...
> 
> TIA!
> ~Simo
> 
> http://people.apache.org/~simonetripodi/
> http://twitter.com/simonetripodi
> 
> On Mon, Jun 24, 2019 at 4:29 PM Simone Tripodi <simonetripodi@apache.org> wrote:
>>
>> Hi all,
>> I would like to start working towards the first apiregions-model [1]
>> bundle release, I would like so to kindly ask if anyone is available
>> for a review before submitting a new [VOTE].
>>
>> Any feedback/suggestion will be more than appreciated, many thanks in advance!
>> ~Simo
>>
>> [1] https://github.com/apache/sling-org-apache-sling-feature-apiregions-model
>>
>> http://people.apache.org/~simonetripodi/
>> http://twitter.com/simonetripodi
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

Mime
View raw message