sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SLING-8408) DistributionQueueHealthCheck should deal with failing queries
Date Wed, 05 Jun 2019 10:41:00 GMT

     [ https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Mueller resolved SLING-8408.
-----------------------------------
    Resolution: Won't Fix

It looks like this wouldn't resolve the issue, as other Sling code swallows exceptions (logs
them as a warning only).

> DistributionQueueHealthCheck should deal with failing queries
> -------------------------------------------------------------
>
>                 Key: SLING-8408
>                 URL: https://issues.apache.org/jira/browse/SLING-8408
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content Distribution
>            Reporter: Thomas Mueller
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The following health check indirectly runs a queries which might fail:
>  * [DistributionQueueHealthCheck|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/monitor/DistributionQueueHealthCheck.java]:
sling-org-apache-sling-distribution-core/src/main/java/org/apache/sling/distribution/monitor
> The call [JobManagerImpl.findJobs|https://github.com/apache/sling-org-apache-sling-event/blob/master/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L373],
which can throw an exception with SLING-8407, if the index is not yet available. The health
checks should catch this exception and return HEALTH_CHECK_ERROR for this case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message