From dev-return-96753-archive-asf-public=cust-asf.ponee.io@sling.apache.org Fri May 10 11:06:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4009518061A for ; Fri, 10 May 2019 13:06:02 +0200 (CEST) Received: (qmail 95941 invoked by uid 500); 10 May 2019 11:06:01 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 95930 invoked by uid 99); 10 May 2019 11:06:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2019 11:06:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7AB5AE20CD for ; Fri, 10 May 2019 11:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2903624597 for ; Fri, 10 May 2019 11:06:00 +0000 (UTC) Date: Fri, 10 May 2019 11:06:00 +0000 (UTC) From: "Konrad Windszus (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-8404) Provide an API-JAR for the XSS Protection API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-8404?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1683= 7193#comment-16837193 ]=20 Konrad Windszus commented on SLING-8404: ---------------------------------------- [~hanspeterstoerr] Thanks for the explanation. I agree that splitting up in= to two bundles is the solution here, one API only bundle and one Impl bundl= e (not exporting any packages, not supposed to be referenced from external)= . Introducing an artificial dependency artifact which is not used at runtim= e should be prevented though. > Provide an API-JAR for the XSS Protection API > --------------------------------------------- > > Key: SLING-8404 > URL: https://issues.apache.org/jira/browse/SLING-8404 > Project: Sling > Issue Type: Improvement > Components: XSS Protection API > Affects Versions: XSS Protection API 2.0.12, XSS Protection API 2.1.8 > Reporter: Hans-Peter Stoerr > Priority: Minor > > The JAR for the org.apache.sling.xss exports only one package, org.apache= .sling.xss, but embeds loads of dependencies it does not export with OSGI. = If one needs this as a maven dependency, you get all that unwanted stuff in= your classpath. In our case it even produced very puzzling compile errors,= since=C2=A0org.apache.sling.xss included commons-beanutils version 1.7.0, = and we used a new method from version 1.8.3. > So, could you please provide an API jar that only contains the org.apache= .sling.xss package? It's interface is so simple that this wouldn't have man= y dependencies. > In case someone else has that problem: we worked around that for now by s= etting org.apache.sling.xss to optional and explicitly importing it only wh= ere that's actually needed in the code. Thus, at least it does not mess up = the classpaths of the artefacts further down the dependency chain; sometime= s it had to be included in test scope, though. -- This message was sent by Atlassian JIRA (v7.6.3#76005)