From dev-return-96561-archive-asf-public=cust-asf.ponee.io@sling.apache.org Sat May 4 20:01:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5B39F180621 for ; Sat, 4 May 2019 22:01:00 +0200 (CEST) Received: (qmail 4477 invoked by uid 500); 4 May 2019 20:00:59 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 4463 invoked by uid 99); 4 May 2019 20:00:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 May 2019 20:00:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 73CBAC2982 for ; Sat, 4 May 2019 20:00:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.904 X-Spam-Level: * X-Spam-Status: No, score=1.904 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_EXCESS_BASE64=0.105, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xxBeFR0Ee9hQ for ; Sat, 4 May 2019 20:00:56 +0000 (UTC) Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 735845F3EF for ; Sat, 4 May 2019 20:00:56 +0000 (UTC) Received: by mail-it1-f193.google.com with SMTP id s3so2406326itk.1 for ; Sat, 04 May 2019 13:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=x931qD6U/eQb2KZyA3M4iTO6qDfYrvuxSv8UtXl9omQ=; b=FlQakmPzQzfX88Tksb5cqNSygpnx9lBcOoq5nwNu5HVYw0+ff+ZU8gGaHiD0MxTcPI EKfDTJg575+AldM656ORsD+22bONVZ+LRUFabhO5cf0MBj2lbstbb0Hc5GMk+0pyUWdh 4w7qmHeTCkjgfcw0TaMrOO44tnuYgsO+1kDiOWfS0NXWXlmFB55qUhTAH/oXrFmIrHqf /jmk9WILduLBLQaQH3JU28t6INthSgWYzXmXRyHawWiBmVCcxgXIJeTIHrfqAK+l8R2/ cOdN35UVUhJvnuXfNrYgWYvi0q6rUjIIhSWolTJTq13goFA8kYkSakV9Ryz66th7PyWy /22A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=x931qD6U/eQb2KZyA3M4iTO6qDfYrvuxSv8UtXl9omQ=; b=j1fIhzGY3vd+2klWO9ryXYeFtwQcxVfRiBv4zfr5DHhsfpmII5BKasGut7Fktrr/Sq 1nYR8dHYxzkk+1FHzhVvfbg8sUdel/wNGs3trldcajoAbp0DR86DU6l71HqKggU1Kyd4 T5+ajrkrwMokLZJisDxq9VLsmmggNV6yBPDTJ5MynfI8X+DDczoNO/XGV5rYg0h+qKC2 +xHUctI+eMFYfZaUWhfTHMTchAui11EIAEkSY+/75JhjQCuwpIKtfp3xBPTZUlHjfwlF //01TZTAAZ/aQWeQP0RSfR/emOKtt80AsdSrIJoS57Yqo1drfHaz4xrSwMLJ0rfF2Np0 0ACg== X-Gm-Message-State: APjAAAUMyncxel+gSGKerh5Lesu8i8MPocDwi4p8VFpUkVsLe+LKmBS1 EbPJqcXoYMipdWYP304TED1c1FGbSz4CqzBsv/fL4g== X-Google-Smtp-Source: APXvYqzwwP5gIkznABW6Fbnx0D80OIQmQ109PtVn9xQcMZk2FjTCoxFtgULWhqiPhss52/B4Utt+tT3xuMh9l+cpUIQ= X-Received: by 2002:a24:7281:: with SMTP id x123mr7407551itc.89.1557000054914; Sat, 04 May 2019 13:00:54 -0700 (PDT) MIME-Version: 1.0 References: <497FA929-FDDB-44B8-BBC9-54A65D9ECE95@me.com> In-Reply-To: <497FA929-FDDB-44B8-BBC9-54A65D9ECE95@me.com> From: =?UTF-8?B?RG9taW5payBTw7zDnw==?= Date: Sat, 4 May 2019 22:00:42 +0200 Message-ID: Subject: Re: Sling Content Package to Feature Model Issue To: dev Content-Type: multipart/alternative; boundary="00000000000030419f05881553a5" --00000000000030419f05881553a5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andy, the behavior you describe supports my hypothesis - as no maven properties are inlined this falls back to the scenario where the converter extracts the details on a best-effort basis from the osgi metadata (which might divert in reality but for the launcher the converter anyways manually prefills the cache so differences to the "original" GAV are acceptable as long as the cache is kept as source of truth and not thrown away. Cheers Dominik On Sat, May 4, 2019 at 9:40 PM Andreas Schaefer wrote: > Created a ticket here: > > https://issues.apache.org/jira/browse/SLING-8396 > > I actually have a content package that did not have any not-provided > bundles in the dependencies and with that the core was added. > > - Andy > > > On May 4, 2019, at 8:26 AM, Dominik S=C3=BC=C3=9F wrote: > > > > Hi Andreas, > > > > if looks like you found a bug in there due to the embedded jars: > > [INFO] Processing bundle core-1.0.0-SNAPSHOT.jar... > > [INFO] Reading 'core-1.0.0-SNAPSHOT.jar' bundle GAV from > > META-INF/maven/com.madplanet.sling.cp2sf/core/pom.properties... > > [INFO] Reading 'core-1.0.0-SNAPSHOT.jar' bundle GAV from > > META-INF/maven/commons-lang/commons-lang/pom.properties... > > > > In fact the referred > > commons-lang:commons-lang:2.6 bundle in that IS the core bundle as it > takes > > the last pom.properties if found and uses those to install the artifac= t. > > Simo already fixed a case where missing pom.properties caused trouble, = in > > this case, I'm not sure how that is supposed to work exactly. > > > > Please open a corresponding bug - Simo will most certainly address this > by > > Monday as he is far deeper in the maven specifics. > > > > Cheers > > Dominik > > > > Andreas Schaefer schrieb am Fr. 3. Mai 2019 > um > > 17:38: > > > >> Hi > >> > >> I have a content package with an embedded Bundle in it (ui.apps -> > core). > >> When running the latest Content Package to Feature Model Converter the > >> bundle is extracted from the package as well as removed from the > filter.xml > >> file but it is not added to the feature model json file. > >> > >> Here is a demo project for it: > >> https://github.com/schaefa/sling-content-2-feature-issue > >> > >> This is the FM json file: > >> > >> > https://github.com/schaefa/sling-content-2-feature-issue/blob/master/fm.o= ut/ui.apps.json > >> > >> When I add the System Console I do not see the bundle. In order to mak= e > it > >> install I had to add it to the ui.apps.json file: > >> > >> "bundles":[ > >> { > >> "id":"commons-lang:commons-lang:2.6", > >> "start-order":"20" > >> }, > >> { > >> "id":"com.madplanet.sling.cp2sf:core:jar:1.0.0-SNAPSHOT", > >> "start-order":"20" > >> }, > >> > >> Is this done on purpose? > >> > >> Cheers - Andy Schaefer > > --00000000000030419f05881553a5--