From dev-return-96951-archive-asf-public=cust-asf.ponee.io@sling.apache.org Mon May 20 21:22:19 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CD1FA180627 for ; Mon, 20 May 2019 23:22:18 +0200 (CEST) Received: (qmail 8303 invoked by uid 500); 20 May 2019 21:22:17 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 8292 invoked by uid 99); 20 May 2019 21:22:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 May 2019 21:22:17 +0000 From: GitBox To: dev@sling.apache.org Subject: [GitHub] [sling-org-apache-sling-scripting-core] paul-bjorkstrand commented on a change in pull request #3: SLING-8425 - Fix NPE on GraalVM Message-ID: <155838733265.8129.8001923211053809802.gitbox@gitbox.apache.org> Date: Mon, 20 May 2019 21:22:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit paul-bjorkstrand commented on a change in pull request #3: SLING-8425 - Fix NPE on GraalVM URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/3#discussion_r285773445 ########## File path: src/main/java/org/apache/sling/scripting/core/impl/jsr223/SlingScriptEngineManager.java ########## @@ -293,13 +293,19 @@ private ScriptEngineManager getInternalScriptEngineManager() { private void registerAssociations(ScriptEngineFactory factory) { for (String extension : factory.getExtensions()) { - internalManager.registerEngineExtension(extension, factory); + if (extension != null && !extension.isEmpty()) { + internalManager.registerEngineExtension(extension, factory); + } } Review comment: Updated. Thanks for the review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services