From dev-return-96740-archive-asf-public=cust-asf.ponee.io@sling.apache.org Fri May 10 09:32:25 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BD9E718061A for ; Fri, 10 May 2019 11:32:24 +0200 (CEST) Received: (qmail 6577 invoked by uid 500); 10 May 2019 09:32:20 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 6566 invoked by uid 99); 10 May 2019 09:32:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2019 09:32:20 +0000 From: GitBox To: dev@sling.apache.org Subject: [GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue #10: SLING-8377 : [BUGFIX] Sling Dynamic Include - Does not support empty "include selector" option. Message-ID: <155748073710.23648.16155791546322223921.gitbox@gitbox.apache.org> Date: Fri, 10 May 2019 09:32:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rombert commented on issue #10: SLING-8377 : [BUGFIX] Sling Dynamic Include - Does not support empty "include selector" option. URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/10#issuecomment-491225339 Thanks a lot for the PR @briankasingli - looks good to me! The only inconvenience right now is that the `master` branch failed to build, so your PR does not build due to being based on a broken version. I have fixed the `master` build, can you please rebase on top of that? Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services