sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SLING-8384) Convertion of configs might miss out properties
Date Thu, 02 May 2019 10:51:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831539#comment-16831539
] 

Simone Tripodi edited comment on SLING-8384 at 5/2/19 10:50 AM:
----------------------------------------------------------------

What happens is that {{.config}} files are parsed via the {{org.apache.felix.cm.file.ConfigurationHandler#read(InputStream)}}
method which transforms multi-values property wrapped in {{(...)}} to a {{Collection}} value,
which is not handled by the [org.apache.sling.feature.io.json.JSONWriterBase#writeConfigurations(JsonGenerator,Configurations)|https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java#L99]

The quick fix will be converting all {{Collection}} instances to arrays.


was (Author: simone.tripodi):
What happens is that {{.config}} files are parsed via the {{org.apache.felix.cm.file.ConfigurationHandler#read(InputStream)}}
method which transforms multi-values property wrapped in {{(...)}} to a {{Collection}} value,
which is not handled by the [org.apache.sling.feature.io.json.JSONWriterBase#writeConfigurations(JsonGenerator,

 Configurations)|https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java#L99]

The quick fix will be converting all {{Collection}} instances to arrays.

> Convertion of configs might miss out properties
> -----------------------------------------------
>
>                 Key: SLING-8384
>                 URL: https://issues.apache.org/jira/browse/SLING-8384
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>            Reporter: Dominik Süß
>            Assignee: Simone Tripodi
>            Priority: Major
>
> The content-package to featuremodel converter seems to miss out some properties (conditions
yet not fully clear). It looks like escaped characters can cause properties to be missed from
the resulting feature model.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message