sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-servlet-helpers] kwin commented on a change in pull request #5: Typo fix in getStatusMessage (was geStatusMessage)
Date Sun, 19 May 2019 16:47:25 GMT
kwin commented on a change in pull request #5: Typo fix in getStatusMessage (was geStatusMessage)
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/5#discussion_r285388479
 
 

 ##########
 File path: src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletResponse.java
 ##########
 @@ -262,6 +262,11 @@ public void setLocale(Locale loc) {
         this.locale = loc;
     }
 
+    public String getStatusMessage() {
+        return statusMessage;
+    }
+    
+    @Deprecated
 
 Review comment:
   Please always give a short reasoning in javadoc what should be used instead of the deprecated
method.
   Also it would be good to call getStatusMessage(), so in case the latter method body is
modified it affects both methods!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message