sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-jcr-contentloader] ncautotest removed a comment on issue #2: SLING-8375 - Allow import if data contains protected properties
Date Fri, 17 May 2019 10:56:55 GMT
ncautotest removed a comment on issue #2: SLING-8375 - Allow import if data contains protected
properties
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/2#issuecomment-493405270
 
 
   @kwin: Thanks! `canSetProperty()` is exactly what I was looking for. Will update the PR
once I finish fixing the related unit test which is now breaking since the method invocation
chain has changed.
   
   Specifically, I'm finding that `org.apache.sling.jcr.contentloader.internal.DefaultContentCreatorTest#testCreateDateProperty()`
is now failing because `node.getPrimaryNodeType().canSetProperty(name, dateValue)` is returning
`false`.
   
   where 
   `name=dateProp` 
   and
    `Value dateValue = node.getSession().getValueFactory().createValue((Calendar) someValue);`.
   
   Is this supposed to work like this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message