sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue #10: SLING-8377 : [BUGFIX] Sling Dynamic Include - Does not support empty "include selector" option.
Date Fri, 10 May 2019 09:32:17 GMT
rombert commented on issue #10: SLING-8377 : [BUGFIX] Sling Dynamic Include - Does not support
empty "include selector" option.
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/10#issuecomment-491225339
 
 
   Thanks a lot for the PR @briankasingli - looks good to me! The only inconvenience right
now is that the `master` branch failed to build, so your PR does not build due to being based
on a broken version. I have fixed the `master` build, can you please rebase on top of that?
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message