From dev-return-95648-archive-asf-public=cust-asf.ponee.io@sling.apache.org Wed Mar 6 20:49:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DDCA7180656 for ; Wed, 6 Mar 2019 21:49:04 +0100 (CET) Received: (qmail 39554 invoked by uid 500); 6 Mar 2019 20:49:03 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 39543 invoked by uid 99); 6 Mar 2019 20:49:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Mar 2019 20:49:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4E424184711 for ; Wed, 6 Mar 2019 20:49:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id xiA2navaTmem for ; Wed, 6 Mar 2019 20:49:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9DC25610F8 for ; Wed, 6 Mar 2019 20:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B0869E2828 for ; Wed, 6 Mar 2019 20:49:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 53CAB2575E for ; Wed, 6 Mar 2019 20:49:00 +0000 (UTC) Date: Wed, 6 Mar 2019 20:49:00 +0000 (UTC) From: "Eric Norman (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-8309?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1678= 6123#comment-16786123 ]=20 Eric Norman commented on SLING-8309: ------------------------------------ Hi=C2=A0Sergiu, FYI: I was also experimenting with enabling support for custom oak commit h= ooks a few months back and the solution I arrived at (but didn't push yet) = is in=C2=A0my github fork at=C2=A0[https://github.com/apache/sling-org-apac= he-sling-jcr-oak-server/compare/master...enapps-enorman:editorprovider]=C2= =A0if you wish to take a look at it.=C2=A0 Your solution looks similar, but= it looks like your pull request may have some duplication of code that alr= eady exists elsewhere regarding tracking the custom components? =C2=A0 =C2=A0 > Allow adding CommitHooks and EditorProviders dynamically from bundles > --------------------------------------------------------------------- > > Key: SLING-8309 > URL: https://issues.apache.org/jira/browse/SLING-8309 > Project: Sling > Issue Type: Improvement > Components: Oak > Reporter: Sergiu Dumitriu > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently, {{OakSlingRepositoryManager}} uses a hard-coded list of {{Comm= itHook}} and {{EditorProvider}} to be used by the Oak repository. This mean= s that other than building a patched version of {{OakSlingRepositoryManager= }} there's no way to include a new commit observer. Ideally, a single pseud= o-\{{CommitHook}} and pseudo-\{{EditorProvider}} should be handled to Oak, = and these should just dynamically aggregate all the=C2=A0{{CommitHook}} and= =C2=A0{{EditorProvider}} instances registered in the {{Whiteboard}}. > All the currently hardcoded components are already available in the white= board, so no functionality will be lost, but this change will automatically= enable support for {{mix:atomicCounter}} via the {{AtomicCounterEditorProv= ider}} that's not used at the moment. > The old behavior should still be available via a new configuration, {{Oak= SlingRepositoryManagerConfiguration#dynamic_components}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)