sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Norman (JIRA)" <>
Subject [jira] [Commented] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles
Date Wed, 06 Mar 2019 20:49:00 GMT


Eric Norman commented on SLING-8309:

Hi Sergiu,

FYI: I was also experimenting with enabling support for custom oak commit hooks a few months
back and the solution I arrived at (but didn't push yet) is in my github fork at [] if
you wish to take a look at it.  Your solution looks similar, but it looks like your pull
request may have some duplication of code that already exists elsewhere regarding tracking
the custom components?



> Allow adding CommitHooks and EditorProviders dynamically from bundles
> ---------------------------------------------------------------------
>                 Key: SLING-8309
>                 URL:
>             Project: Sling
>          Issue Type: Improvement
>          Components: Oak
>            Reporter: Sergiu Dumitriu
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
> Currently, {{OakSlingRepositoryManager}} uses a hard-coded list of {{CommitHook}} and
{{EditorProvider}} to be used by the Oak repository. This means that other than building a
patched version of {{OakSlingRepositoryManager}} there's no way to include a new commit observer.
Ideally, a single pseudo-\{{CommitHook}} and pseudo-\{{EditorProvider}} should be handled
to Oak, and these should just dynamically aggregate all the {{CommitHook}} and {{EditorProvider}}
instances registered in the {{Whiteboard}}.
> All the currently hardcoded components are already available in the whiteboard, so no
functionality will be lost, but this change will automatically enable support for {{mix:atomicCounter}}
via the {{AtomicCounterEditorProvider}} that's not used at the moment.
> The old behavior should still be available via a new configuration, {{OakSlingRepositoryManagerConfiguration#dynamic_components}}.

This message was sent by Atlassian JIRA

View raw message