sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SLING-8305) Embed Cocoon XMLSerializer
Date Wed, 06 Mar 2019 10:00:10 GMT

     [ https://issues.apache.org/jira/browse/SLING-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Konrad Windszus updated SLING-8305:
-----------------------------------
    Description: 
The XMLSerializer (https://github.com/apache/sling-org-apache-sling-rewriter/blob/669f2074ae550781cd7745422f8b3d17b1045892/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java#L48)
extends the Cocoon one from {{org.apache.cocoon.components.serializers.util.XMLSerializer}}.
The latter is a third party dependency which is marked as optional import via https://github.com/apache/sling-org-apache-sling-rewriter/blob/669f2074ae550781cd7745422f8b3d17b1045892/bnd.bnd#L12.

Neither in the slingstarter nor in AEM 6.4.1 this 3rd party dependency is shipped by default.

But since the factory from https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java
is always being registered you run in such cases into a CNFE at run time.

I would suggest to just embed the cocon XML serializer into the rewriter bundle to remove
that run time dependency.

  was:
The XMLSerializer (https://github.com/apache/sling-org-apache-sling-rewriter/blob/669f2074ae550781cd7745422f8b3d17b1045892/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java#L48)
extends the Cocoon one from {{org.apache.cocoon.components.serializers.util.XMLSerializer}}.
The latter is a third party dependency which is marked as optional import via https://github.com/apache/sling-org-apache-sling-rewriter/blob/669f2074ae550781cd7745422f8b3d17b1045892/bnd.bnd#L12.

Neither in the slingstarter nor in AEM 6.4.1 this 3rd party dependency is shipped by default.

But since the factory from https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java
is always being registered you run in such cases into a CNFE at run time.


> Embed Cocoon XMLSerializer
> --------------------------
>
>                 Key: SLING-8305
>                 URL: https://issues.apache.org/jira/browse/SLING-8305
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Rewriter 1.2.2
>            Reporter: Konrad Windszus
>            Priority: Major
>
> The XMLSerializer (https://github.com/apache/sling-org-apache-sling-rewriter/blob/669f2074ae550781cd7745422f8b3d17b1045892/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java#L48)
extends the Cocoon one from {{org.apache.cocoon.components.serializers.util.XMLSerializer}}.
The latter is a third party dependency which is marked as optional import via https://github.com/apache/sling-org-apache-sling-rewriter/blob/669f2074ae550781cd7745422f8b3d17b1045892/bnd.bnd#L12.
> Neither in the slingstarter nor in AEM 6.4.1 this 3rd party dependency is shipped by
default. 
> But since the factory from https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java
is always being registered you run in such cases into a CNFE at run time.
> I would suggest to just embed the cocon XML serializer into the rewriter bundle to remove
that run time dependency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message