From dev-return-95031-archive-asf-public=cust-asf.ponee.io@sling.apache.org Fri Jan 25 11:42:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AB586180608 for ; Fri, 25 Jan 2019 11:42:05 +0100 (CET) Received: (qmail 80171 invoked by uid 500); 25 Jan 2019 10:42:04 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 80160 invoked by uid 99); 25 Jan 2019 10:42:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jan 2019 10:42:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4B049C5572 for ; Fri, 25 Jan 2019 10:42:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 46oK_yAq3fqE for ; Fri, 25 Jan 2019 10:42:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 342D56109D for ; Fri, 25 Jan 2019 10:42:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 43F09E26A4 for ; Fri, 25 Jan 2019 10:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4C1AE24312 for ; Fri, 25 Jan 2019 10:42:00 +0000 (UTC) Date: Fri, 25 Jan 2019 10:42:00 +0000 (UTC) From: "Carsten Ziegeler (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-8239) I18NFilter is executed too often per request MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752140#comment-16752140 ] Carsten Ziegeler commented on SLING-8239: ----------------------------------------- I'm not sure, it seems there are different wrappers created. I'm also not sure how useful the filter is for other contexts than Sling If we only use the http filter than that filter can't access any Sling information (user, resource resolver etc) > I18NFilter is executed too often per request > -------------------------------------------- > > Key: SLING-8239 > URL: https://issues.apache.org/jira/browse/SLING-8239 > Project: Sling > Issue Type: Bug > Components: i18n > Affects Versions: i18n 2.5.0 > Reporter: Konrad Windszus > Priority: Major > > With SLING-5940 the {{I18NFilter}} is registered as Filter with the OSGi HTTP whiteboard but still in addition as Sling Filter (compare with https://github.com/apache/sling-org-apache-sling-i18n/commit/f770fe132ce0cbdab3cae980ac01298bb7baf10d). > That leads to the fact that the filter is being called at least twice for a very simple request. Once first via the OSGi HTTP Whiteboard and then from the Sling Main Servlet as Sling-specific REQUEST filter. > [~cziegeler] Do we still need to register this filter as Sling filter or is HTTP Whiteboard sufficient. I am not sure though about the "ERROR" scope. -- This message was sent by Atlassian JIRA (v7.6.3#76005)