From dev-return-95020-archive-asf-public=cust-asf.ponee.io@sling.apache.org Thu Jan 24 15:22:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3193418062C for ; Thu, 24 Jan 2019 15:22:06 +0100 (CET) Received: (qmail 69100 invoked by uid 500); 24 Jan 2019 14:22:05 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 69089 invoked by uid 99); 24 Jan 2019 14:22:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jan 2019 14:22:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C5B5EC1801 for ; Thu, 24 Jan 2019 14:22:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ImGDHqKcpsg1 for ; Thu, 24 Jan 2019 14:22:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A29A760E10 for ; Thu, 24 Jan 2019 14:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 145BEE26A3 for ; Thu, 24 Jan 2019 14:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 36095242C7 for ; Thu, 24 Jan 2019 14:22:00 +0000 (UTC) Date: Thu, 24 Jan 2019 14:22:00 +0000 (UTC) From: "Nicolas Peltier (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (SLING-8236) remove toString from ModelAdapterFactory.clearDisposalCallbackRegistryQueue debug log MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-8236?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-8236. ------------------------------------ Resolution: Fixed Assignee: Nicolas Peltier Fix Version/s: Sling Models Impl 1.4.12 > remove toString from ModelAdapterFactory.clearDisposalCallbackRegistryQue= ue debug log=20 > -------------------------------------------------------------------------= ------------- > > Key: SLING-8236 > URL: https://issues.apache.org/jira/browse/SLING-8236 > Project: Sling > Issue Type: Improvement > Components: General > Affects Versions: Sling Models Impl 1.4.10 > Reporter: Nicolas Peltier > Assignee: Nicolas Peltier > Priority: Major > Fix For: Sling Models Impl 1.4.12 > > Time Spent: 20m > Remaining Estimate: 0h > > {{log.debug("calling disposal for {}.", ref.toString());}} > itself is responsible for huge char[]=C2=A0allocation. Removing it is ver= y quick and painless perf improvement (figures coming ahead), as toString w= ill be called as well, but only in debug mode. -- This message was sent by Atlassian JIRA (v7.6.3#76005)