From dev-return-94813-archive-asf-public=cust-asf.ponee.io@sling.apache.org  Mon Jan 14 16:46:42 2019
Return-Path: <dev-return-94813-archive-asf-public=cust-asf.ponee.io@sling.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 04ADA180675
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 14 Jan 2019 16:46:41 +0100 (CET)
Received: (qmail 9603 invoked by uid 500); 14 Jan 2019 15:46:40 -0000
Mailing-List: contact dev-help@sling.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@sling.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@sling.apache.org>
List-Post: <mailto:dev@sling.apache.org>
List-Id: <dev.sling.apache.org>
Reply-To: dev@sling.apache.org
Delivered-To: mailing list dev@sling.apache.org
Received: (qmail 9592 invoked by uid 99); 14 Jan 2019 15:46:40 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Jan 2019 15:46:40 +0000
From: GitBox <git@apache.org>
To: dev@sling.apache.org
Subject: [GitHub] kwin commented on a change in pull request #1: Sling 3270
Message-ID: <154748080032.8530.18371895485077717081.gitbox@gitbox.apache.org>
Date: Mon, 14 Jan 2019 15:46:40 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

kwin commented on a change in pull request #1: Sling 3270
URL: https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r247543378
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -37,25 +37,36 @@
 
     <properties>
         <sling.java.version>8</sling.java.version>
-        <org.ops4j.pax.exam.version>4.11.0</org.ops4j.pax.exam.version>
+        <org.ops4j.pax.exam.version>4.12.0</org.ops4j.pax.exam.version>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <project.resources.sourceEncoding>UTF-8</project.resources.sourceEncoding>
     </properties>
 
     <scm>
         <connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git</connection>
         <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git</developerConnection>
         <url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git</url>
-      <tag>HEAD</tag>
-  </scm>
+        <tag>HEAD</tag>
+    </scm>
 
     <build>
         <plugins>
             <plugin>
-                <groupId>biz.aQute.bnd</groupId>
-                <artifactId>bnd-maven-plugin</artifactId>
 
 Review comment:
   @JEBailey I don't know either what is wrong with bnd in that case, but thanks a lot for the dedicated test branch. I created the ticket https://github.com/bndtools/bnd/issues/2859 to follow-up on that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services