sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-8239) I18NFilter is executed too often per request
Date Fri, 25 Jan 2019 10:42:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752140#comment-16752140
] 

Carsten Ziegeler commented on SLING-8239:
-----------------------------------------

I'm not sure, it seems there are different wrappers created.
I'm also not sure how useful the filter is for other contexts than Sling
If we only use the http filter than that filter can't access any Sling information (user,
resource resolver etc)


> I18NFilter is executed too often per request
> --------------------------------------------
>
>                 Key: SLING-8239
>                 URL: https://issues.apache.org/jira/browse/SLING-8239
>             Project: Sling
>          Issue Type: Bug
>          Components: i18n
>    Affects Versions: i18n 2.5.0
>            Reporter: Konrad Windszus
>            Priority: Major
>
> With SLING-5940 the {{I18NFilter}} is registered as Filter with the OSGi HTTP whiteboard
but still in addition as Sling Filter (compare with https://github.com/apache/sling-org-apache-sling-i18n/commit/f770fe132ce0cbdab3cae980ac01298bb7baf10d).
> That leads to the fact that the filter is being called at least twice for a very simple
request. Once first via the OSGi HTTP Whiteboard and then from the Sling Main Servlet as Sling-specific
REQUEST filter.
> [~cziegeler] Do we still need to register this filter as Sling filter or is HTTP Whiteboard
sufficient. I am not sure though about the "ERROR" scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message