sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Burkhard Pauli (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SLING-8186) Moved node is deleted if @Delete parameter points to its name
Date Wed, 09 Jan 2019 10:30:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738071#comment-16738071
] 

Burkhard Pauli edited comment on SLING-8186 at 1/9/19 10:29 AM:
----------------------------------------------------------------

[~bdelacretaz], Thank you for having a look into this issue! I think in this edge case the
question is if we can reorder the modify operations like in the attached  [^patch.diff] ,
so that the move and copy operation is done after the delete. Otherwise the delete will remove
the copied or moved file right after in the same request. 

Sure, this will change the old (undocumented) behaviour but I can't imagine use cases where
the old behaviour is intended because the move operation will delete the resource anyway and
the motivation to copy a resource is to keep the source resource. Otherwise the move operation
should be used. Or do I miss something? 

cc [~cziegeler]


was (Author: bupauli):
[~bdelacretaz], Thank you for having a look into this issue! I think in this edge case the
question is if we can reorder the modify operations like in the attached  [^patch.diff] ,
so that the move and copy operation is done after the delete. Otherwise the delete will remove
the copied or moved file right after in the same request. 

Sure, this will change the old (undocumented) behaviour but I can't imagine use cases where
the old behaviour is intended because the move operation will delete the resource anyway and
the motivation to copy a resource is to keep the old example. Otherwise the move operation
should be used. Or do I miss something? 

cc [~cziegeler]

> Moved node is deleted if @Delete parameter points to its name
> -------------------------------------------------------------
>
>                 Key: SLING-8186
>                 URL: https://issues.apache.org/jira/browse/SLING-8186
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>    Affects Versions: Servlets Post 2.3.26
>            Reporter: Burkhard Pauli
>            Assignee: Bertrand Delacretaz
>            Priority: Major
>         Attachments: patch.diff
>
>
> If a file is moved to a new location with the @MoveFrom parameter and the request contains
the @Delete parameter at the same time, the file is dropped and never saved to the new location.
> Step to reproduce the issue:
>  # Create a node of type nt:file at the location {{/content/file}}
>  # Execute the following curl command:
>  {{curl -u admin:admin -F './test/title=Hello World' -F './test/file@MoveFrom=/content/file'
-F './test@Delete=true' [http://localhost:4502/content]}}
> Observed behaviour:
>  The file is not saved at the new location at {{/content/test/file}} and it is not available
anymore at the old location {{/content/file}}
> Expected:
>  The file is saved at the new location {{/content/test/file}} as long as other properties
are saved when the request contains the delete operation (like the title property in the example
above).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message