sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Radu Cotescu <r...@apache.org>
Subject Re: SLING-7245 - Proposal for PR validation of all Sling modules
Date Mon, 07 Jan 2019 13:35:34 GMT
Hi Robert,

How far are we from being able to merge https://github.com/apache/sling-tooling-jenkins/tree/feature/SLING-7245
<https://github.com/apache/sling-tooling-jenkins/tree/feature/SLING-7245> back to master?

I really like the new approach of generating Jenkins jobs, after having migrated the 3 experimental
scripting bundle tracker modules.

Thanks,
Radu

> On 18 Dec 2018, at 12:20, Robert Munteanu <rombert@apache.org> wrote:
> 
> Hi,
> 
> I've been experimenting how we can get Jenkins to validate PRs that are
> opened against our Github modules with SLING-7245 [1]. I now have a
> working POC that I would like to discuss with the dev list.
> 
> The major changes are:
> 
> - switching from a Maven module build to a Multipipeline build
> - switching from job creation using the Job DSL plug-in to using a
> GitHub organisation folder
> 
> The end result you can see (for the sling whiteboard only) in the
> folder at [2]. It automatically created a job for the whiteboard and it
> also builds the pull requests [3], with results at [4].
> 
> One downside is that I am still my account so my avatar appears all
> over the pull requests, which is IMO not ideal. But that's something we
> can explore later.
> 
> At this point I would like to ask you to check if this sort of setup
> fits your expected usage. One notable change is that XML parsing is
> quite difficult in this setup so I tentatively moved from a .sling-
> module.xml descriptor to a .sling-module.json one, to make it
> consumable on Jenkins. Not sure if anyone was using it outside of
> Jenkins though.
> 
> Thoughts?
> 
> Thanks,
> 
> Robert
> 
> 
> [1]: https://issues.apache.org/jira/browse/SLING-7245
> [2]: https://builds.apache.org/job/Sling%20(pipeline%20jobs)/
> [3]: 
> https://builds.apache.org/job/Sling%20(pipeline%20jobs)/job/sling-whiteboard/view/change-requests/
> [4]: https://github.com/apache/sling-whiteboard/pull/23
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message