sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Munteanu <romb...@apache.org>
Subject Re: ValueMapDecorator using impl class in api
Date Tue, 22 Jan 2019 12:42:17 GMT
Hi Roy,

On Tue, 2019-01-22 at 13:35 +0100, Roy Teeuwen wrote:
> Hey dev's,
> 
> Since the use of the ObjectConverter, the ValueMapDecorator class
> which is in the api package bundle, uses an impl class. Is this good
> practice?
> 
> See 
> https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/wrappers/ValueMapDecorator.java
> <
> https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/wrappers/ValueMapDecorator.java
> >

The usage of the class is not exposed, so IMO there is no problem with
it.

> 
> We are for example using the uber-jar provided by Adobe for their
> product, AEM. This uber-jar only contains the api classes that you
> should program your code against, but now since this change our unit
> tests fail because the ValueMapDecorator uses an impl class that is
> not available in this uber jar.

Then I guess that's a problem with the Adobe uber-jar. That impl class
is part of the api bundle, there's no reason not to use it.

Robert


Mime
View raw message