From dev-return-94388-archive-asf-public=cust-asf.ponee.io@sling.apache.org Thu Dec 13 23:11:57 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C0E5E180609 for ; Thu, 13 Dec 2018 23:11:56 +0100 (CET) Received: (qmail 10275 invoked by uid 500); 13 Dec 2018 22:11:55 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 10264 invoked by uid 99); 13 Dec 2018 22:11:55 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Dec 2018 22:11:55 +0000 Received: from [192.168.100.88] (unknown [51.154.18.231]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id AE942B01 for ; Thu, 13 Dec 2018 22:11:54 +0000 (UTC) From: Radu Cotescu Content-Type: multipart/alternative; boundary="Apple-Mail=_033D21D2-AE47-40F2-9C36-C4A09AC010A5" Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [VOTE] Release Apache Sling API 2.20.0, Apache Sling Servlets Resolver 2.5.0, Apache Sling Servlet Annotations 1.2.2 Date: Thu, 13 Dec 2018 23:11:53 +0100 References: <67FE14EE-7A05-46A0-B173-C906875D9B33@apache.org> <86D50B5D-0C44-4D2B-8C49-83130C29AB67@apache.org> <582F4C56-4B79-43CC-98CF-90A336595029@gmx.de> To: Sling Dev In-Reply-To: <582F4C56-4B79-43CC-98CF-90A336595029@gmx.de> Message-Id: X-Mailer: Apple Mail (2.3445.102.3) --Apple-Mail=_033D21D2-AE47-40F2-9C36-C4A09AC010A5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Konrad, > On 13 Dec 2018, at 19:44, Konrad Windszus wrote: >=20 > Hi Radu, > I don't really understand the fix in = https://github.com/apache/sling-org-apache-sling-servlets-annotations/comm= it/9cc022fa517a858e96229e8629b0102914abb435 = . > The previous default (i.e. null) should lead to the fact that the = service property is not generated if there is no value set. Now the = property is always generated! The former seems to be the more correct = approach. Especially if I want to generate servlets targeting pre 2.5.0 = servlet resolver. > Can you explain? >=20 > Thanks, > Konrad There was no default value before - which would force consumers to = specify a value in all annotations - and =E2=80=9Cnull=E2=80=9D is not = an allowed default value [0][1]. An empty string value would not be = taken into consideration by the o.a.s.servlets.resolver, but maybe a = better option would be to specify =E2=80=9Csling/servlet/default=E2=80=9D?= ! Cheers, Radu [0] - = https://docs.oracle.com/javase/specs/jls/se11/html/jls-9.html#jls-9.6.2 = [1] - = https://builds.apache.org/job/sling-org-apache-sling-servlets-annotations-= it-1.8/97/console = --Apple-Mail=_033D21D2-AE47-40F2-9C36-C4A09AC010A5--