sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Georg Henzler (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SLING-7245) Validate pull requests using Jenkins
Date Wed, 19 Dec 2018 23:10:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725426#comment-16725426
] 

Georg Henzler edited comment on SLING-7245 at 12/19/18 11:09 PM:
-----------------------------------------------------------------

[~rombert] Does it make sense to maintain a Jenkinsfile and a file .sling-module.json in parallel? Instead
of parsing that json file at [1] I would just use the properties as passed in to slingOsgiBundleBuild()...
that way you stay in groovy and you can pass in closures as well which allows something like:
{code}
slingOsgiBundleBuild(
    jdks: [ 8, 9 ],
    specialPostBuildActionForThisBundle: {
        echo("Only for this bundle I want to do this")
    }
)
{code}
(not that we need this now, but I think it's better to stay in groovy for advanced use cases
in the future)

[1] https://github.com/apache/sling-tooling-jenkins/blob/14402a4cfeec86e539c79473487c13eb72889b7f/vars/slingOsgiBundleBuild.groovy#L25


was (Author: henzlerg):
[~rombert] Does it make sense to maintain a Jenkinsfile and a file .sling-module.json in parallel? Instead
of parsing that json file at [1] I would just use the properties as passed in to slingOsgiBundleBuild()...
that way you stay in groovy and you can pass in closures as well which allows something like:
{code}
slingOsgiBundleBuild(
    "jdks": [ 8, 9 ],
    specialPostBuildActionForThisBundle: {
        echo("Only for this bundle I want to do this")
    }
)
{code}
(not that we need this now, but I think it's better to stay in groovy for advanced use cases
in the future)

[1] https://github.com/apache/sling-tooling-jenkins/blob/14402a4cfeec86e539c79473487c13eb72889b7f/vars/slingOsgiBundleBuild.groovy#L25

> Validate pull requests using Jenkins
> ------------------------------------
>
>                 Key: SLING-7245
>                 URL: https://issues.apache.org/jira/browse/SLING-7245
>             Project: Sling
>          Issue Type: Improvement
>          Components: Build and Source Control
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message