sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rombert commented on a change in pull request #1: Sling 3270
Date Wed, 05 Dec 2018 11:16:52 GMT
rombert commented on a change in pull request #1: Sling 3270
URL: https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r239025221
 
 

 ##########
 File path: src/main/java/org/apache/sling/commons/html/impl/parser/ParseException.java
 ##########
 @@ -0,0 +1,187 @@
+/* Generated By:JavaCC: Do not edit this line. ParseException.java Version 5.0 */
 
 Review comment:
   Do we need to commit the generated code to source control? I think there are options to
generate it at build time using Maven and then included in the packaged jar, without adding
it to source control.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message