From dev-return-93844-archive-asf-public=cust-asf.ponee.io@sling.apache.org Thu Nov 15 16:48:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0CA3E180679 for ; Thu, 15 Nov 2018 16:48:03 +0100 (CET) Received: (qmail 50802 invoked by uid 500); 15 Nov 2018 15:48:02 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 50605 invoked by uid 99); 15 Nov 2018 15:48:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2018 15:48:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 68FEE181014 for ; Thu, 15 Nov 2018 15:48:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GzPHl-mHl7Jt for ; Thu, 15 Nov 2018 15:48:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1F7126242C for ; Thu, 15 Nov 2018 15:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B9FF1E2072 for ; Thu, 15 Nov 2018 15:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 643212135B for ; Thu, 15 Nov 2018 15:48:00 +0000 (UTC) Date: Thu, 15 Nov 2018 15:48:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-8104) Avoid magic when merging features MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688246#comment-16688246 ] ASF GitHub Bot commented on SLING-8104: --------------------------------------- bosschaert commented on issue #8: SLING-8104 Avoid magic when merging features URL: https://github.com/apache/sling-org-apache-sling-feature/pull/8#issuecomment-439086668 Note that the slingfeature-maven-plugin changes to provide the artifact override list is being developed here: https://github.com/bosschaert/sling-slingfeature-maven-plugin/tree/SLING-8104 @cziegeler @karlpauls WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Avoid magic when merging features > --------------------------------- > > Key: SLING-8104 > URL: https://issues.apache.org/jira/browse/SLING-8104 > Project: Sling > Issue Type: Improvement > Components: Feature Model > Reporter: Carsten Ziegeler > Assignee: David Bosschaert > Priority: Blocker > Fix For: slingfeature-maven-plugin 1.0.0, Feature Model 0.2.2 > > > Currently when features are merged a simple algorithm is applied which just picks the highest version based on the artifact version. However this version might not have no meaning at all and might not really reflect what has changed inside the bundle. > Especially when there is a major version change, this approach seems to be clearly wrong > But in the end, picking a single version is magic. > While the problem could probably be solved by using something like a resolver and figure out if just one version is enough or if both versions are needed, without a resolver there is no way to figure this out. > Therefore we should provide a similar way as we do for variables at the moment: if there is a clash the caller needs to provide context on what to choose. -- This message was sent by Atlassian JIRA (v7.6.3#76005)