sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
Date Thu, 08 Nov 2018 16:21:35 GMT
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able
to validate JSON Feature file against the JSON Schema
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231959205
 
 

 ##########
 File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
 ##########
 @@ -404,6 +455,7 @@ public Feature provide(final ArtifactId id) {
 
 	                    // "external" dependency, we can already resolve it
 	                    final File featureFile = ProjectHelper.getOrResolveArtifact(info.project,
env.session, env.artifactHandlerManager, env.resolver, id).getFile();
+	                    checkFeatureFileValidation(featureFile);
 
 Review comment:
   I think we should not validate external features as these are released in maven already
and therefore should be validated already

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message