sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
Date Thu, 08 Nov 2018 11:35:53 GMT
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature
file against the JSON Schema
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436965172
 
 
   Ah yes, you're right of course. the validation is too late.
   So we should probably move the validation out of the mojo into the Preprocessor (which
reads the json files). The method preprocessFeature looks like a good place to add the validation.
   This method currently does
   
   - variable substitution
   - adds the "id" property if it is missing
   
   So I think we should change that method to:
   - add the "id" property if it is missing
   - validate the feature
   - variable substitution
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message