From dev-return-92135-archive-asf-public=cust-asf.ponee.io@sling.apache.org Tue Oct 2 09:39:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A2286180677 for ; Tue, 2 Oct 2018 09:39:05 +0200 (CEST) Received: (qmail 52722 invoked by uid 500); 2 Oct 2018 07:39:04 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 52645 invoked by uid 99); 2 Oct 2018 07:39:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Oct 2018 07:39:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 922F0C6A34 for ; Tue, 2 Oct 2018 07:39:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SnGMdIavoX_F for ; Tue, 2 Oct 2018 07:39:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 62FCF5F51F for ; Tue, 2 Oct 2018 07:39:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BB8BBE25D5 for ; Tue, 2 Oct 2018 07:39:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3D92A27762 for ; Tue, 2 Oct 2018 07:39:00 +0000 (UTC) Date: Tue, 2 Oct 2018 07:39:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-7968) FeatureModelConverter should use FeatureProvider instead of ArtifactManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635106#comment-16635106 ] ASF GitHub Bot commented on SLING-7968: --------------------------------------- bosschaert commented on issue #1: SLING-7968: Use FeatureProvider instead of ArtifactManager. URL: https://github.com/apache/sling-org-apache-sling-feature-modelconverter/pull/1#issuecomment-426178399 Interestingly enough I came across a similar situation when working on the API Whitelisting. In my case I need to map an Artifact (or ArtifactId) to something like an InputStream or File. If we refactor the FeatureProvider to a more general ArtifactProvider that returns an InputStream we might be able to use the same interface for multiple use-cases? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > FeatureModelConverter should use FeatureProvider instead of ArtifactManager > --------------------------------------------------------------------------- > > Key: SLING-7968 > URL: https://issues.apache.org/jira/browse/SLING-7968 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes > Affects Versions: Slingstart Maven Plugin 1.8.2, Feature Model Converter 0.1.2 > Reporter: Karl Pauls > Priority: Major > Fix For: Feature Model Converter 0.1.4, Slingstart Maven Plugin 1.8.4 > > Time Spent: 10m > Remaining Estimate: 0h > > The feature model converter currently requires an ArtifactManager. This is not needed and can be replaced with the less powerful FeatureProvider. Subsequently, we can use the simpler interface to actually use the maven resolver to resolve features in the Slingstart Maven Plugin (instead of using a ArtifactManager when invoking the model convert. -- This message was sent by Atlassian JIRA (v7.6.3#76005)