From dev-return-92350-archive-asf-public=cust-asf.ponee.io@sling.apache.org Tue Oct 9 12:15:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 87245180668 for ; Tue, 9 Oct 2018 12:15:03 +0200 (CEST) Received: (qmail 62029 invoked by uid 500); 9 Oct 2018 10:15:02 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 62018 invoked by uid 99); 9 Oct 2018 10:15:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2018 10:15:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2B974C06DC for ; Tue, 9 Oct 2018 10:15:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 5TPcniuQXhKg for ; Tue, 9 Oct 2018 10:15:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 028375F175 for ; Tue, 9 Oct 2018 10:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7DED1E0177 for ; Tue, 9 Oct 2018 10:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 27A6F247C7 for ; Tue, 9 Oct 2018 10:15:00 +0000 (UTC) Date: Tue, 9 Oct 2018 10:15:00 +0000 (UTC) From: "Konrad Windszus (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-7756) Improve logging for Job retries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643082#comment-16643082 ] Konrad Windszus commented on SLING-7756: ---------------------------------------- [~indra2gurjar] Sorry for the late answer, but I think the log level is actually fine for the retry (i.e. for case [1]) but should be definitely enriched so that it is clearer that a retry has been issued. For the case [0] I think we should switch to a WARN at least and include there information about number of retries as well. > Improve logging for Job retries > ------------------------------- > > Key: SLING-7756 > URL: https://issues.apache.org/jira/browse/SLING-7756 > Project: Sling > Issue Type: Improvement > Components: Event > Affects Versions: Event 4.2.10 > Reporter: Konrad Windszus > Priority: Major > > Currently a {{JobConsumer}} returning {{JobResult.FAILED}} is usually retried (https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html). Unfortunately this is not exposed in the logs, so in case a JobConsumer logs an error before returning {{JobResult.FAILED}} the job is silently retried without any particular log message. I think each failed job should lead to a WARN in the log (in case the job is retried) with the attempt number and outstanding attempts in the log message. In case a job is not retried, an ERROR should be emitted to the log for every failed job. -- This message was sent by Atlassian JIRA (v7.6.3#76005)