sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
Date Mon, 08 Oct 2018 14:42:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641919#comment-16641919
] 

ASF GitHub Bot commented on SLING-7988:
---------------------------------------

simonetripodi opened a new pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks
by id, in order to enable specific Tasks in the Maven plugin
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5
 
 
   Hi there @bosschaert,
   please have a look at the initial implementation of my proposal.
   
   I moved few utility static methods from Analyzer class to a proper dedicated Task provider
implementation, in order to have separation of concerns and better unit testing.
   
   I also implemented a new unit test, all old tests still pass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
> -------------------------------------------------------------------------------------------------
>
>                 Key: SLING-7988
>                 URL: https://issues.apache.org/jira/browse/SLING-7988
>             Project: Sling
>          Issue Type: Improvement
>          Components: Feature Model, Maven Plugins and Archetypes
>            Reporter: Simone Tripodi
>            Assignee: David Bosschaert
>            Priority: Major
>
> Current Maven Feature Plugin Analyze MOJO executes all tasks in the classpath, it should
be possible to select them via the typical include/exclude plugin configuration pattern.
> A first initial modification is needed in the Analyzer component, I am going to submit
a PR about it - once applied, the Maven plugin can be modified in order to select tasks to
perform during the analysis



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message