sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7932) Use Regex to parse mvn GAVs and URLs
Date Wed, 10 Oct 2018 08:55:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644662#comment-16644662
] 

ASF GitHub Bot commented on SLING-7932:
---------------------------------------

bdelacretaz commented on issue #4: SLING-7932 - Use Regex to parse mvn GAVs and URLs
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/4#issuecomment-428492267
 
 
   +1 to what @bosschaert says - if the original parser works, don't fix it ;-)
   
   Note that our parent pom includes a Jacoco setup to quickly check test coverage, build
with `-P jacoco-report` and see the `target/site/jacoco-merged/index.html` report. Before
these changes the report indeed shows some code paths which are not tested in `ArtifactId#fromMvnUrl`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use Regex to parse mvn GAVs and URLs
> ------------------------------------
>
>                 Key: SLING-7932
>                 URL: https://issues.apache.org/jira/browse/SLING-7932
>             Project: Sling
>          Issue Type: Improvement
>          Components: Feature Model
>            Reporter: Simone Tripodi
>            Assignee: David Bosschaert
>            Priority: Trivial
>
> Current implementations work, but they can become a little easier to maintain by replacing
few lines of manual implemented parsers, with smart regex.
> Pull Request is coming and new tests will be added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message