sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7756) Improve logging for Job retries
Date Tue, 09 Oct 2018 10:15:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643082#comment-16643082
] 

Konrad Windszus commented on SLING-7756:
----------------------------------------

[~indra2gurjar]
Sorry for the late answer, but I think the log level is actually fine for the retry (i.e.
for case [1]) but should be definitely enriched so that it is clearer that a retry has been
issued.
For the case [0] I think we should switch to a WARN at least and include there information
about number of retries as well.

> Improve logging for Job retries
> -------------------------------
>
>                 Key: SLING-7756
>                 URL: https://issues.apache.org/jira/browse/SLING-7756
>             Project: Sling
>          Issue Type: Improvement
>          Components: Event
>    Affects Versions: Event 4.2.10
>            Reporter: Konrad Windszus
>            Priority: Major
>
> Currently a {{JobConsumer}} returning {{JobResult.FAILED}} is usually retried (https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html).
Unfortunately this is not exposed in the logs, so in case a JobConsumer logs an error before
returning {{JobResult.FAILED}} the job is silently retried without any particular log message.
I think each failed job should lead to a WARN in the log (in case the job is retried) with
the attempt number and outstanding attempts in the log message. In case a job is not retried,
an ERROR should be emitted to the log for every failed job.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message