sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7429) Improve basename handling
Date Tue, 09 Oct 2018 10:33:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643099#comment-16643099
] 

Konrad Windszus commented on SLING-7429:
----------------------------------------

I propose to change 2. to 
{quote}Empty String, selects messages of mix:language nodes which have no sling:basename property
or one with an empty value{quote}

I think this is way more in line what the user expects. This is a potentially backward-incompatible
change though, but I don't can come up with a use case where you are actually interested in
dictionaries having arbitrary (but explicitly set) basenames.

[~alexander.klimetschek] Since you contributed a lot to i18n in the past, WDYT about this?

> Improve basename handling
> -------------------------
>
>                 Key: SLING-7429
>                 URL: https://issues.apache.org/jira/browse/SLING-7429
>             Project: Sling
>          Issue Type: Improvement
>          Components: i18n
>    Affects Versions: i18n 2.5.12
>            Reporter: Konrad Windszus
>            Priority: Major
>
> Right now the basename handling according to https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#resourcebundle-with-base-names
is as follows
> {quote}
> The base name argument can take one three values:
> # {{null}}, selects messages of mix:language nodes ignoring the existence or absence
of sling:basename properties
> # Empty String, selects messages of mix:language nodes which have sling:basename properties,
ignoring the actual values
> # Any other Value, selects messages of mix:language nodes whose sling:basename properties
has any value which matches the base name string
> {quote}
> I think it should somehow be also possible for a client to explicitly select a resource
bundle which is not having the {{sling:basename}} property set.
> This was originally triggered from https://issues.apache.org/jira/browse/SLING-7421?focusedCommentId=16335686&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16335686.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message