From dev-return-92055-archive-asf-public=cust-asf.ponee.io@sling.apache.org Fri Sep 28 12:38:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 67EE9180627 for ; Fri, 28 Sep 2018 12:38:03 +0200 (CEST) Received: (qmail 15290 invoked by uid 500); 28 Sep 2018 10:38:02 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 15276 invoked by uid 99); 28 Sep 2018 10:38:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2018 10:38:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DC527C2DB9 for ; Fri, 28 Sep 2018 10:38:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fcR6bXIidT0X for ; Fri, 28 Sep 2018 10:38:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 27A6A5F10C for ; Fri, 28 Sep 2018 10:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 90777E00CB for ; Fri, 28 Sep 2018 10:38:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1C9A323F9C for ; Fri, 28 Sep 2018 10:38:00 +0000 (UTC) Date: Fri, 28 Sep 2018 10:38:00 +0000 (UTC) From: =?utf-8?Q?J=C3=B6rg_Hoh_=28JIRA=29?= To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-7960) Repoinit: delete user does not distinguish between system user and regular user MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7960?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1663= 1677#comment-16631677 ]=20 J=C3=B6rg Hoh commented on SLING-7960: --------------------------------- It looks to me, that the implementation of both visitDeleteUser and visitDe= leteServiceUser are identical. =C2=A0 See [https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/mas= ter/src/main/java/org/apache/sling/jcr/repoinit/impl/UserVisitor.java#L94] = and [https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/mas= ter/src/main/java/org/apache/sling/jcr/repoinit/impl/UserVisitor.java#L60] There should be an additional check that deleteUser does not accidently del= ete a service user. > Repoinit: delete user does not distinguish between system user and regula= r user > -------------------------------------------------------------------------= ------ > > Key: SLING-7960 > URL: https://issues.apache.org/jira/browse/SLING-7960 > Project: Sling > Issue Type: Improvement > Components: Repoinit > Affects Versions: Repoinit JCR 1.1.8 > Reporter: J=C3=B6rg Hoh > Priority: Major > Attachments: SLING-7960.patch > > > My current application uses a regular user, but with some changes to the = framework we need to migrate to regular service users. The service user is = being added as part of the deployment. > To automate this I decided to use the repoinit to remove the regular user= and then deploy the service user. Which works fine, but only until the nex= t time the repoinit is executed again. Because then the repoinit statement > {{delete user foo}} > purges the newly created serviceuser "foo". It would be great if there wo= uld be an distinction between deleting regular users and deleting service u= sers, as it is on creation as well. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)