From dev-return-91758-archive-asf-public=cust-asf.ponee.io@sling.apache.org Tue Sep 18 17:29:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CFEC3180672 for ; Tue, 18 Sep 2018 17:29:04 +0200 (CEST) Received: (qmail 66585 invoked by uid 500); 18 Sep 2018 15:29:03 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 66574 invoked by uid 99); 18 Sep 2018 15:29:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2018 15:29:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4A2CF1A0136 for ; Tue, 18 Sep 2018 15:29:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id yXpVfmihY42O for ; Tue, 18 Sep 2018 15:29:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5DB965F3B2 for ; Tue, 18 Sep 2018 15:29:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DB649E1328 for ; Tue, 18 Sep 2018 15:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5996F23FA3 for ; Tue, 18 Sep 2018 15:29:00 +0000 (UTC) Date: Tue, 18 Sep 2018 15:29:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-7925) Donate new AnalyzerTask which is able to validate APIs/Regions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619288#comment-16619288 ] ASF GitHub Bot commented on SLING-7925: --------------------------------------- bosschaert commented on issue #1: SLING-7925 - Donate new AnalyzerTask which is able to validate APIs/Regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/1#issuecomment-422439963 Hi @simonetripodi thanks for this pull request! It looks good to me. Would it be possible to also add some unit tests for the code please? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Donate new AnalyzerTask which is able to validate APIs/Regions > --------------------------------------------------------------- > > Key: SLING-7925 > URL: https://issues.apache.org/jira/browse/SLING-7925 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes > Reporter: Simone Tripodi > Assignee: David Bosschaert > Priority: Major > Attachments: SLING-7925.1.patch, SLING-7925.2.patch, SLING-7925.patch, emptyApiRegions.json, errorsDetected.json, noErrorsDetected.json > > > According to open discussion on SLING-7779, I started using a subset of the features described, then in order to produce valid results I had the need to implement a validator which detects discrepancies between what is declared in the {{export}} section of each region and what is really exported by bundles enlisted in the feature itself. > The verification works in order to accept a feature files directory as a input, supports the typical {{(in|ex)cludes}} Maven pattern, validation works locally per-featurefile and doesn't support the global validation. > Patch, including integration tests, is coming! -- This message was sent by Atlassian JIRA (v7.6.3#76005)