From dev-return-91350-archive-asf-public=cust-asf.ponee.io@sling.apache.org Mon Sep 10 16:50:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 04CD218067A for ; Mon, 10 Sep 2018 16:50:13 +0200 (CEST) Received: (qmail 14386 invoked by uid 500); 10 Sep 2018 14:50:13 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 14368 invoked by uid 99); 10 Sep 2018 14:50:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Sep 2018 14:50:12 +0000 From: GitBox To: dev@sling.apache.org Subject: [GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes Message-ID: <153659101240.24278.7061420874726418582.gitbox@gitbox.apache.org> Date: Mon, 10 Sep 2018 14:50:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216351430 ########## File path: src/main/java/org/apache/sling/pipes/PipeBuilder.java ########## @@ -252,6 +253,36 @@ description = "read multi property, and output each value in the bindings") PipeBuilder mp(); + /** + * attach an ACL pipe to the current context + * @param conf configuration parameters + * @return updated instance of PipeBuilder + * @throws IllegalAccessException in case it's called with bad configuration + */ + @PipeExecutor(command = "acls", resourceType = ACLPipe.RESOURCE_TYPE, pipeClass = ACLPipe.class, + description = "output each acls on the resource or acls for authorizable in repository in bindings") + PipeBuilder acls(Object... conf) throws IllegalAccessException; + + /** + * attach an ACL pipe to the current context and sets allow acls on the resource + * @param conf configuration parameters + * @return updated instance of PipeBuilder + * @throws IllegalAccessException in case it's called with bad configuration + */ + @PipeExecutor(command = "allow", resourceType = ACLPipe.RESOURCE_TYPE, pipeClass = ACLPipe.class, + description = "sets allow acls on the resource") + PipeBuilder allow(String expr) throws IllegalAccessException; + + /** + * attach an ACL pipe to the current context and sets deny acls on the resource + * @param conf configuration parameters Review comment: please remove absent parameter from javadoc here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services