sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7941) Use streaming APIs to serialize a Feature to the related JSON representation
Date Mon, 24 Sep 2018 14:07:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625863#comment-16625863
] 

ASF GitHub Bot commented on SLING-7941:
---------------------------------------

bosschaert commented on issue #4: SLING-7941 - Use streaming APIs to marshall the Feature
to JSON
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/4#issuecomment-423986784
 
 
   LGTM, I originally did the opposite as I couldn't get the JsonGenerator to do pretty printing:
https://github.com/apache/sling-whiteboard/commit/6b51e9f49b25848214c1717dfa8ac7f729b7d986
but this would definitely be more efficient.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use streaming APIs to serialize a Feature to the related JSON representation
> ----------------------------------------------------------------------------
>
>                 Key: SLING-7941
>                 URL: https://issues.apache.org/jira/browse/SLING-7941
>             Project: Sling
>          Issue Type: Improvement
>          Components: Feature Model
>    Affects Versions: Feature Model IO 0.1.4
>            Reporter: Simone Tripodi
>            Assignee: David Bosschaert
>            Priority: Major
>
> We can avoid the unnecessary intermediate JSON objects creation by replacing current
usage with {{javax.json.JsonGenerator}} APIs, when serializing a {{Feature}} to the related
JSON representation.
> Pull request is coming, tests keep working as before.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message