sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7925) Donate new AnalyzerTask which is able to validate APIs/Regions
Date Tue, 18 Sep 2018 15:29:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619288#comment-16619288
] 

ASF GitHub Bot commented on SLING-7925:
---------------------------------------

bosschaert commented on issue #1: SLING-7925 - Donate new AnalyzerTask which is able to validate
APIs/Regions
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/1#issuecomment-422439963
 
 
   Hi @simonetripodi thanks for this pull request! It looks good to me.
   Would it be possible to also add some unit tests for the code please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Donate new AnalyzerTask which is able to validate APIs/Regions 
> ---------------------------------------------------------------
>
>                 Key: SLING-7925
>                 URL: https://issues.apache.org/jira/browse/SLING-7925
>             Project: Sling
>          Issue Type: New Feature
>          Components: Feature Model, Maven Plugins and Archetypes
>            Reporter: Simone Tripodi
>            Assignee: David Bosschaert
>            Priority: Major
>         Attachments: SLING-7925.1.patch, SLING-7925.2.patch, SLING-7925.patch, emptyApiRegions.json,
errorsDetected.json, noErrorsDetected.json
>
>
> According to open discussion on SLING-7779, I started using a subset of the features
described, then in order to produce valid results I had the need to implement a validator
which detects discrepancies between what is declared in the {{export}} section of each region
and what is really exported by bundles enlisted in the feature itself.
> The verification works in order to accept a feature files directory as a input, supports
the typical {{(in|ex)cludes}} Maven pattern, validation works locally per-featurefile and
doesn't support the global validation.
> Patch, including integration tests, is coming!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message