sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin
Date Thu, 06 Sep 2018 13:59:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605818#comment-16605818
] 

Konrad Windszus commented on SLING-6344:
----------------------------------------

Since version 1.0.3 the filevault-package-maven-plugin (http://jackrabbit.apache.org/filevault-package-maven-plugin/index.html)
supports generating filter.xml out of plugin configuration in a dedicated step (which is also
executed via m2e within Eclipse). That makes it possible to leverage the generated {{filter.xml}}
also in the Sling IDE. I need to check what needs to be changed in the Sling IDE sources to
properly support generated {{filter.xml}} files.

> Support filter.xmls being generated by the content-package-maven-plugin
> -----------------------------------------------------------------------
>
>                 Key: SLING-6344
>                 URL: https://issues.apache.org/jira/browse/SLING-6344
>             Project: Sling
>          Issue Type: Bug
>          Components: IDE
>    Affects Versions: Sling Eclipse IDE 1.1.0
>            Reporter: Konrad Windszus
>            Priority: Critical
>             Fix For: Sling Eclipse IDE 1.2.4
>
>         Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the source directory,
but also generate or merge filter.xmls. Therefore Sling IDE should consider only the filter.xml
in the generated artifacts (package). The problem with that is, that content-package-maven-plugin
does only generate that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the method {{ResourceChangeCommandFactory#getFilterResult}}
returns {{ALLOW}} while it should return {{DENY}} to not overwrite any nodes in case the filter
rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType of the root
node in the JCR from {{rep:root}} to {{nt:unstructured}} and the resourceType from {{sling:redirect}}
to just being removed which breaks the redirect handling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message