From dev-return-90499-archive-asf-public=cust-asf.ponee.io@sling.apache.org Wed Aug 8 11:41:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B5A7B18077A for ; Wed, 8 Aug 2018 11:41:04 +0200 (CEST) Received: (qmail 92837 invoked by uid 500); 8 Aug 2018 09:41:03 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 92826 invoked by uid 99); 8 Aug 2018 09:41:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2018 09:41:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 211D01803DF for ; Wed, 8 Aug 2018 09:41:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id OTVm0A5i4F35 for ; Wed, 8 Aug 2018 09:41:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AF7095F492 for ; Wed, 8 Aug 2018 09:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E7E29E2613 for ; Wed, 8 Aug 2018 09:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6B28123FA2 for ; Wed, 8 Aug 2018 09:41:00 +0000 (UTC) Date: Wed, 8 Aug 2018 09:41:00 +0000 (UTC) From: "Julian Sedding (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (SLING-7813) SlingHttpServletResponseImpl should log when setStatus is called after it is committed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7813?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated SLING-7813: ---------------------------------- Fix Version/s: (was: Engine 2.6.12) Engine 2.6.14 > SlingHttpServletResponseImpl should log when setStatus is called after it= is committed > -------------------------------------------------------------------------= ------------- > > Key: SLING-7813 > URL: https://issues.apache.org/jira/browse/SLING-7813 > Project: Sling > Issue Type: Improvement > Components: Engine > Affects Versions: Engine 2.6.12 > Reporter: Julian Sedding > Assignee: Julian Sedding > Priority: Minor > Fix For: Engine 2.6.14 > > Time Spent: 0.5h > Remaining Estimate: 0h > > I have been debugging a scenario, where a response did not have the (in t= his case) expected status code {{500}} set by an error handling script, but= instead the status code was {{200}}. > It turns out that a rendering script calls {{#flushBuffer()}} on the resp= onse early on in order to optimize user experience. Later in the rendering = chain a JSP causes a {{NullPointerException}}, triggering an error handler = which calls {{#setStatus(500)}}. The {{#setStatus}}=C2=A0call is silently i= gnored. > "Fixing" this problem would require buffering the entire response and ign= oring any flush calls (be it {{#flushBuffer()}}, {{#getWriter().flush()}} o= r {{#getOutputStream().flush()}}). This would be a change in behaviour, a v= iolation of the Servlet spec and performance issues waiting to happen. Thus= I am ruling out this option. > However, it would be helpful to improve "debuggability" of the problem. I= propose to log a warning when {{#setStatus()}} is called. Additionally, if= debug logging is enabled, I propose to log a stack trace to identify where= the flush call originated (unless the flush was due to too many bytes writ= ten, which is not very helpful information). > cc [~rombert] -- This message was sent by Atlassian JIRA (v7.6.3#76005)