sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7840) Image rendering broken on sling.apache.org
Date Sun, 26 Aug 2018 11:50:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592872#comment-16592872
] 

Konrad Windszus commented on SLING-7840:
----------------------------------------

yes, I reverted with https://github.com/apache/sling-site/commit/2e1fce78e1f88e62e2d0cf662f72e2ecacf7079d.

> Image rendering broken on sling.apache.org
> ------------------------------------------
>
>                 Key: SLING-7840
>                 URL: https://issues.apache.org/jira/browse/SLING-7840
>             Project: Sling
>          Issue Type: Bug
>          Components: Site
>            Reporter: Robert Munteanu
>            Priority: Critical
>         Attachments: broken-images.txt
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> While reviewing https://github.com/apache/sling-site/pull/19 we discovered that image
links are rendered:
> 1. always with the sling.apache.org domain ( so images added locally will not be considered
)
> 1. with a wrong path, no longer appending the parents of the current page
> So the image links at both
> * http://localhost:8820/documentation/development/ide-tooling.html
> * https://sling.apache.org/documentation/development/ide-tooling.html
> are broken, being rendered as http://sling.apache.org/ide-tooling/new-server.png, whereas
they should be
> * http://localhost:8820/documentation/development/ide-tooling/new-server.png
> * https://sling.apache.org/documentation/development/ide-tooling/new-server.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message