From dev-return-90025-archive-asf-public=cust-asf.ponee.io@sling.apache.org Thu Jul 19 11:26:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 262BA180630 for ; Thu, 19 Jul 2018 11:26:04 +0200 (CEST) Received: (qmail 69284 invoked by uid 500); 19 Jul 2018 09:26:04 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 69273 invoked by uid 99); 19 Jul 2018 09:26:04 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jul 2018 09:26:04 +0000 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 1EC38CF6 for ; Thu, 19 Jul 2018 09:26:03 +0000 (UTC) Received: by mail-lj1-f173.google.com with SMTP id f1-v6so4962929ljc.9 for ; Thu, 19 Jul 2018 02:26:02 -0700 (PDT) X-Gm-Message-State: AOUpUlFoVG1GoA5o1b1N5vSgPUY6Gl1gLex8yb2zSM68MKSQt8wstI4i SDXRCtrx2nwGEIPvsEcq0S9ZVKDQmWowsgyqJqc= X-Google-Smtp-Source: AAOMgpfE3KDTXKZrQzQAlPccnNizynXQEFPWrelsiGwJZRhXKpfqdZx1/hkU58kRZGhbWHxX0LtVv6rjnY9+BUOIe3o= X-Received: by 2002:a2e:2ac3:: with SMTP id q186-v6mr6955038ljq.123.1531992362018; Thu, 19 Jul 2018 02:26:02 -0700 (PDT) MIME-Version: 1.0 References: <2ab383dfd263b53806ee8886c5dfe04ccd382fe9.camel@apache.org> In-Reply-To: From: Bertrand Delacretaz Date: Thu, 19 Jul 2018 09:25:50 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: SLING-7613 - un-deprecating loginAdministrative To: dev Content-Type: text/plain; charset="UTF-8" Hi, On Tue, Jul 17, 2018 at 1:43 PM Justin Edelson wrote: > ...Without the deprecation, how will a developer know that they need to > configure the whitelist? While the deprecation wasn't perfect, at least it > gave the developer the sense that they were doing something which should be > avoided. It is unfortunate that deprecation in Java is such a binary > concept, but it is what it is... I agree with Justin here, I think our intention is to say "do not use this method unless you really have to and you know what you are doing" and also "note that you have to whitelist bundles which uses this". That's not the standard meaning of a deprecated Java method, but as Justin says we don't want developers to miss that restriction and deprecation is a workable (and imperfect) way of doing that. With this in mind I suggest keeping the deprecation, creating a website page that explains what it actually means and linking to that page in the javadocs. -Bertrand