sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7784) Unable to add comments to the removals → bundles section
Date Wed, 25 Jul 2018 15:10:01 GMT

    [ https://issues.apache.org/jira/browse/SLING-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555813#comment-16555813
] 

Carsten Ziegeler commented on SLING-7784:
-----------------------------------------

As far as I can tell, comments are currently only allowed as keys, but not for a value

> Unable to add comments to the removals → bundles section
> --------------------------------------------------------
>
>                 Key: SLING-7784
>                 URL: https://issues.apache.org/jira/browse/SLING-7784
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>            Reporter: Robert Munteanu
>            Priority: Major
>
> With a configuration such as
> {code}
>   includes: [
>         {
>             "id":"com.example:example:some-feature:1.0.0",
>             "removals": {
>                 "bundles": [
>                     "# this is a comment",
>                     "something:something-else:1.9"
>                 ]
>             }
>         }
>   ]
> {code}
> I get an error saying that
> {noformat}java.io.IOException: Error reading feature: features/app.json
> 	at org.apache.sling.feature.applicationbuilder.impl.Main.assembleApplication(Main.java:231)
> 	at org.apache.sling.feature.applicationbuilder.impl.Main.main(Main.java:200)
> Caused by: java.io.IOException: java.lang.IllegalArgumentException: Unable to parse mvn
coordinates/url: # this is a comment
> 	at org.apache.sling.feature.io.json.FeatureJSONReader.read(FeatureJSONReader.java:80)
> 	at org.apache.sling.feature.io.json.FeatureJSONReader.read(FeatureJSONReader.java:57)
> 	at org.apache.sling.feature.io.IOUtils.getFeature(IOUtils.java:180)
> 	at org.apache.sling.feature.applicationbuilder.impl.Main.assembleApplication(Main.java:226)
> 	... 1 more
> Caused by: java.lang.IllegalArgumentException: Unable to parse mvn coordinates/url: #
this is a comment
> 	at org.apache.sling.feature.ArtifactId.parse(ArtifactId.java:96)
> 	at org.apache.sling.feature.io.json.FeatureJSONReader.readIncludes(FeatureJSONReader.java:213)
> 	at org.apache.sling.feature.io.json.FeatureJSONReader.readFeature(FeatureJSONReader.java:144)
> 	at org.apache.sling.feature.io.json.FeatureJSONReader.read(FeatureJSONReader.java:78)
> 	... 4 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message