sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Sedding (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7759) add other "patterns" than path for filters
Date Thu, 05 Jul 2018 08:31:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533399#comment-16533399
] 

Julian Sedding commented on SLING-7759:
---------------------------------------

[~npeltier] I created a pull request from my fork to yours. If you merge that in, attribution
is not lost. And if you decide to squash commits, don't worry about the attribution, I'm not
too bothered.

bq. [...] test over & over presence of a given configuration [...]

Do you mean the null checks? If that's the case, I wouldn't worry. If it's something else,
please explain again, because I didn't understand.




> add other "patterns" than path for filters
> ------------------------------------------
>
>                 Key: SLING-7759
>                 URL: https://issues.apache.org/jira/browse/SLING-7759
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.6.12
>            Reporter: Nicolas Peltier
>            Assignee: Nicolas Peltier
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}} allows to include
them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy &  add sling.filter.pattern.path
for consistency with what follow) regexp matches current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix  passes if sling.filter.pattern.suffix regep matches current suffix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message