From dev-return-89089-archive-asf-public=cust-asf.ponee.io@sling.apache.org Sat Jun 2 12:49:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D4453180676 for ; Sat, 2 Jun 2018 12:49:04 +0200 (CEST) Received: (qmail 29463 invoked by uid 500); 2 Jun 2018 10:49:03 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 29452 invoked by uid 99); 2 Jun 2018 10:49:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Jun 2018 10:49:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 42D8FC00DA for ; Sat, 2 Jun 2018 10:49:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.5 X-Spam-Level: X-Spam-Status: No, score=-109.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_SHORT=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id GO86EOoHpX0j for ; Sat, 2 Jun 2018 10:49:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 991945F5FA for ; Sat, 2 Jun 2018 10:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9F81AE08C7 for ; Sat, 2 Jun 2018 10:49:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 22B2321094 for ; Sat, 2 Jun 2018 10:49:00 +0000 (UTC) Date: Sat, 2 Jun 2018 10:49:00 +0000 (UTC) From: "Konrad Windszus (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (SLING-7658) XSSApi.encodeForHtml doesn't leave unicode character escapes untouched MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498990#comment-16498990 ] Konrad Windszus edited comment on SLING-7658 at 6/2/18 10:48 AM: ----------------------------------------------------------------- Actually even {{XSSFilter.filter(...)}} doesn't leave unicode escape sequences untouched but rather unescapes those. Please see the attached failing test [^SLING-7658-v02.patch]. This is an issue for HTML which is not using UTF-8! As this issue is no longer related to this original issue I created SLING-7703 for the new issue and close this one as Won't fix. was (Author: kwin): Actually even {{XSSFilter.filter(...)}} doesn't leave unicode escape sequences untouched but rather unescapes those. Please see the attached failing test [^SLING-7658-v02.patch]. This is an issue for HTML which is not using UTF-8! > XSSApi.encodeForHtml doesn't leave unicode character escapes untouched > ---------------------------------------------------------------------- > > Key: SLING-7658 > URL: https://issues.apache.org/jira/browse/SLING-7658 > Project: Sling > Issue Type: Bug > Components: XSS Protection API > Affects Versions: XSS Protection API 2.1.0 > Reporter: Konrad Windszus > Priority: Major > Attachments: SLING-7658-v01.patch, SLING-7658-v02.patch > > > Whenever {{encodeForHtml}} is called with a string containing a unicode character escapes (https://www.w3.org/International/questions/qa-escapes#answer), the {{&}} gets escaped again. I.e. {{✅}} becomes {{✅}}. > Compare with the discussion at https://www.mail-archive.com/dev@sling.apache.org/msg76863.html. > Attached is a patch with a failing test. > Another use case for using unicode character escapes is the soft hyphen (https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens#Suggesting_line_break_opportunities). -- This message was sent by Atlassian JIRA (v7.6.3#76005)