From dev-return-89597-archive-asf-public=cust-asf.ponee.io@sling.apache.org Fri Jun 22 16:13:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E3F28180647 for ; Fri, 22 Jun 2018 16:13:13 +0200 (CEST) Received: (qmail 64339 invoked by uid 500); 22 Jun 2018 14:13:05 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 64284 invoked by uid 99); 22 Jun 2018 14:13:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jun 2018 14:13:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9A5C8182516 for ; Fri, 22 Jun 2018 14:13:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id BzqyKBQXmuVx for ; Fri, 22 Jun 2018 14:13:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D30355F57D for ; Fri, 22 Jun 2018 14:13:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B6355E0F96 for ; Fri, 22 Jun 2018 14:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CF65B23FAD for ; Fri, 22 Jun 2018 14:13:00 +0000 (UTC) Date: Fri, 22 Jun 2018 14:13:00 +0000 (UTC) From: "Radu Cotescu (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (SLING-7516) ResourceRuntimeExtension: Selectors containing a comma are not treated correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-7516. ------------------------------- > ResourceRuntimeExtension: Selectors containing a comma are not treated correctly > -------------------------------------------------------------------------------- > > Key: SLING-7516 > URL: https://issues.apache.org/jira/browse/SLING-7516 > Project: Sling > Issue Type: Bug > Components: Scripting > Affects Versions: Scripting HTL Engine 1.0.48-1.3.1 > Reporter: Konrad Windszus > Assignee: Radu Cotescu > Priority: Major > Labels: patch-available > Fix For: Scripting HTL Engine 1.0.54-1.4.0 > > > Due to the way how the request dispatcher options are serialized into one big string in https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/cd7d67e66f624c66fe88dd208c4d2b8f7e85c8ec/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/ResourceRuntimeExtension.java#L214 you cannot use e.g. selectors which contain a comma. This is a problem because currently selectors are the only way to propagate parameters from one HTL script to another script/servlet (compare with SLING-7515). > The method {{createDispatcherOptions}} generates a String from a Map where the entries are separated by {{,}} i.e. comma. If either the map key or the map value contain a comma itself the tokenization in https://github.com/apache/sling-org-apache-sling-api/blob/ec3dcf291b26e833b07a1f9c485bbe713a7ad4d5/src/main/java/org/apache/sling/api/request/RequestDispatcherOptions.java#L100 works incorrectly! > Therefore instead of using the constructor with a string (with very simple/incorrect parsing) the {{RequestDispatcherOptions}} should rather be created with an empty string and then the map should be filled with the according put/set methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)